New plugin BaselineFixGradleJava #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
fawind
approved these changes
Feb 24, 2020
|
Released 3.5.0 |
This was referenced Feb 24, 2020
This was referenced Feb 24, 2020
This was referenced Feb 26, 2020
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Users can resolve configurations like
compile,runtimeandcompileOnly, which are meant to be buckets of dependencies (you can only add dependencies to them), never actually resolved or depended on.Also, resolving these can trigger a Gradle bug - gradle/gradle#11844 (comment) - when running code that attempts to resolve all resolvable configurations. This bug seems to be encountered less often when these configurations are not being resolved.
After this PR
==COMMIT_MSG==
A new
com.palantir.baseline-fix-gradle-javaplugin fixes up the deprecated configurations of java source sets so they cannot be resolved or depended on.==COMMIT_MSG==
Possible downsides?
This can break external plugins. I think this is a good opportunity to discover these problems though, as later the same break will be introduced in Gradle 7. And as mentioned in Before this PR, the fact that these are resolvable is already causing some problems.