Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back checkUnusedDependencies.ignore and checkImplicitDependencies.ignore #1273

Merged
merged 8 commits into from
Mar 2, 2020
Merged

Add back checkUnusedDependencies.ignore and checkImplicitDependencies.ignore #1273

merged 8 commits into from
Mar 2, 2020

Conversation

dansanduleac
Copy link
Contributor

@dansanduleac dansanduleac commented Mar 2, 2020 •
edited
Loading

Before this PR

We broke some "API" that was being used by gradle-conjure in #1262, namely the ignore method on a task named exactly checkUnusedDependencies.

After this PR

==COMMIT_MSG==
Bring back the ignore(String, String) method on the checkUnusedDependencies and checkImplicitDependencies tasks. This now ignores the coordinate for all source sets.
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Mar 2, 2020 •
edited by dansanduleac
Loading

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Bring back the ignore(String, String) method on the checkUnusedDependencies and checkImplicitDependencies tasks. This now ignores the coordinate for all source sets.

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from iamdanfox March 2, 2020 11:41
@dansanduleac
Copy link
Contributor Author

@CRogers I think we should bring back this functionality on the checkImplicitDependencies task too.. No plugin is configuring that one, but the break might still be annoying to people.

@dansanduleac dansanduleac requested review from CRogers and removed request for iamdanfox March 2, 2020 11:48
@dansanduleac dansanduleac changed the title Add back checkUnusedDependencies.ignore Add back checkUnusedDependencies.ignore and checkImplicitDependencies.ignore Mar 2, 2020
@dansanduleac dansanduleac removed the request for review from CRogers March 2, 2020 12:00
@bulldozer-bot bulldozer-bot bot merged commit 2dd0fa0 into develop Mar 2, 2020
@bulldozer-bot bulldozer-bot bot deleted the ds/add-back-checkUnusedDependencies-ignore branch March 2, 2020 12:07
@svc-autorelease
Copy link
Collaborator

Released 3.7.2

This was referenced Jun 22, 2021
Closed
Closed
Open
Merged
This was referenced Sep 15, 2021
Closed
Closed
Closed
@svc-excavator-bot svc-excavator-bot mentioned this pull request Nov 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CRogers CRogers CRogers approved these changes

Assignees
No one assigned
Labels
autorelease merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dansanduleac @svc-autorelease @CRogers