Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable left curl when using palantir-java-format #1278

Merged
merged 3 commits into from
Mar 3, 2020
Merged

Disable left curl when using palantir-java-format #1278

merged 3 commits into from
Mar 3, 2020

Conversation

ferozco
Copy link
Contributor

@ferozco ferozco commented Mar 3, 2020 •
edited
Loading

Before this PR

@mglazer flagged an issue where PJF and checkstyle were fighting where a scope was defined within a switch statement

After this PR

==COMMIT_MSG==
Disable LeftCurly CheckStyle rule when Palantir-Java-Format is applied
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Mar 3, 2020 •
edited by ferozco
Loading

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Disable LeftCurly CheckStyle rule when Palantir-Java-Format is applied

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from fawind March 3, 2020 03:50
@ferozco ferozco requested a review from dansanduleac March 3, 2020 03:52
@carterkozak
Copy link
Contributor

Mind linking/describing the scenario where then analyzers disagree?
It might make sense to collocate PJF and our checkstyle configurations at some point so we can test outputs pass both.

@carterkozak
Copy link
Contributor

👍

@bulldozer-bot bulldozer-bot bot merged commit 308d499 into develop Mar 3, 2020
@bulldozer-bot bulldozer-bot bot deleted the fo/disable-left-curly branch March 3, 2020 14:20
@svc-autorelease
Copy link
Collaborator

Released 3.7.4

@pkoenig10 pkoenig10 mentioned this pull request Jan 6, 2021
Merged
This was referenced Jun 22, 2021
Closed
Closed
Open
Merged
This was referenced Sep 15, 2021
Closed
Closed
Closed
@svc-excavator-bot svc-excavator-bot mentioned this pull request Nov 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mglazer mglazer mglazer approved these changes

@fawind fawind Awaiting requested review from fawind

@dansanduleac dansanduleac Awaiting requested review from dansanduleac

Assignees
No one assigned
Labels
autorelease merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ferozco @carterkozak @svc-autorelease @mglazer