Update spotless to 5.7.0 #1534
Merged
Update spotless to 5.7.0 #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
ferozco
reviewed
Nov 10, 2020
gradle-baseline-java/src/test/groovy/com/palantir/baseline/BaselineFormatIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
ferozco
reviewed
Nov 10, 2020
| @@ -4,9 +4,10 @@ | |||
| /** | |||
| * Docstring that looks like a list: | |||
| * | |||
| * <p>1. hey 2. there | |||
| * 1. hey | |||
There was a problem hiding this comment.
We bumped the version of palantir-java-formatter that we use in tests from 0.3.9 to 1.1.0 which added some changes to how the formatted output looks:
https://github.com/palantir/gradle-baseline/pull/1534/files#diff-c2c619cc6bd6031ee10ada015c7ba9b841732e59d0a05d2a7408ebb0c02501e9L37-R37
ferozco
approved these changes
Nov 10, 2020
|
Released 3.49.0 |
iamdanfox
reviewed
Nov 11, 2020
| @@ -1,4 +1,4 @@ | |||
| com.diffplug.spotless:spotless-plugin-gradle = 4.4.0 | |||
| com.diffplug.spotless:spotless-plugin-gradle = 5.7.0 | |||
There was a problem hiding this comment.
confirmed this is in managed-artifacts.txt :)
There was a problem hiding this comment.
Yep, this excavator also tries to upgrade it but the tests fail because of the breaking changes: 286964e#diff-c2c619cc6bd6031ee10ada015c7ba9b841732e59d0a05d2a7408ebb0c02501e9L1-R1
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR
Update spotless to newest version as part of picking up support for new java syntax features. This PR works in combination with updating spotless in palantir-java-format: palantir/palantir-java-format#358.
==COMMIT_MSG==
Update spotless to 5.7.0
==COMMIT_MSG==
Possible downsides?
Minimum Gradle version required by spotless also gets bumped from 2.14 to 5.4 (source)