Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smarter CheckExplicitSourceCompatibilityTask #1577

Merged
merged 2 commits into from
Dec 1, 2020
Merged

Smarter CheckExplicitSourceCompatibilityTask #1577

merged 2 commits into from
Dec 1, 2020

Conversation

iamdanfox
Copy link
Contributor

@iamdanfox iamdanfox commented Dec 1, 2020 •
edited
Loading

Before this PR

@pkoenig10 received a baseline upgrade on MP which failed CI asking for a sourceCompatibility line onthe root project, because our docs plugin was applying the PublishingPlugin just to get the publish lifecycle task created.

After this PR

==COMMIT_MSG==
Smarter CheckExplicitSourceCompatibilityTask
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Dec 1, 2020 •
edited by iamdanfox
Loading

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

baseline-reproducibility no longer requires people to set sourceCompatibility if the publishing plugin is applied but nothing is published.

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from ferozco December 1, 2020 02:52
@bulldozer-bot bulldozer-bot bot merged commit 1488b74 into develop Dec 1, 2020
@bulldozer-bot bulldozer-bot bot deleted the dfox-patch-22540 branch December 1, 2020 03:33
@svc-autorelease
Copy link
Collaborator

Released 3.58.2

This was referenced Jun 22, 2021
Closed
Closed
Merged
Merged
Closed
Open
Merged
Merged
Merged
Merged
This was referenced Sep 15, 2021
Closed
Closed
Closed
Closed
@svc-excavator-bot svc-excavator-bot mentioned this pull request Nov 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkoenig10 pkoenig10 pkoenig10 approved these changes

@ferozco ferozco Awaiting requested review from ferozco

Assignees
No one assigned
Labels
autorelease merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamdanfox @svc-autorelease @pkoenig10