Don't modify exact dependencies index #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkoenig10
force-pushed
the
pkoenig/classToDependency
branch
from
23a9289 to
7b1bb14
Compare
pkoenig10
force-pushed
the
pkoenig/classToDependency
branch
from
7b1bb14 to
ac087d8
Compare
fawind
approved these changes
Jan 21, 2021
|
Released 3.66.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
The values in the
classToDependencyindex can be modified if the same class is produced by multiple artifacts and subprojects are not all using the same artifact to provide this class.This can happen quite easily when using our internal jakarta renames plugin.
After this PR
The
classToDependencyindex stores sets of artifacts that provide a given class. ThecheckUnusedDependenciesandcheckImplicitDependenciestasks have been updated to handle multiple artifacts as gracefully as possible.This was pretty trivial for the
checkUnusedDependenciestask. It was a bit more involved for thecheckImplicitDependenciestask since we have to treat the potential artifacts as a conjunctive normal form.