Baseline applies the -parameters javac option for method parameter metadata
#1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
…metadata This produces bytecode with method paramter metadata to support more powerful reflection features and stronger error-prone automated migrations.
carterkozak
force-pushed
the
ckozak/apply_parameters
branch
from
5404e90 to
0ceb2b6
Compare
CRogers
reviewed
Mar 18, 2021
| project.getTasks() | ||
| .withType(JavaCompile.class) | ||
| .configureEach(javaCompileTask -> | ||
| javaCompileTask.getOptions().getCompilerArgs().add("-parameters")); |
There was a problem hiding this comment.
I looked to see if there was any downsides of doing this and found these: https://stackoverflow.com/a/44075684/139766. None of them seem that bad.
|
👍 |
|
Released 3.75.0 |
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
No parameter metadata.
After this PR
This produces bytecode with method parameter metadata to support
more powerful reflection features and stronger automated migrations.
==COMMIT_MSG==
Baseline applies the
-parametersjavac option for method parameter metadata==COMMIT_MSG==
Possible downsides?
Not sure how to test this. The change is pretty simple though, and we don't need to worry about applying the
-parametersoption twice becausejavacdoesn't mind.