recommend witchcraft logging #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
commented
Aug 6, 2021
|
|
||
| private static boolean hasJavaServiceDistributionPluginLoaded() { | ||
| try { | ||
| Class.forName('com.palantir.gradle.dist.service.JavaServiceDistributionPlugin') |
There was a problem hiding this comment.
Won't work using the plugins {} dsl, but we don't use that at this point.
carterkozak
changed the title
|
I've manually verified that this functions as expected for both gradle integration and ipr workflows. |
fawind
approved these changes
Aug 9, 2021
|
Released 4.10.0 |
This was referenced Aug 9, 2021
Merged
This was referenced Aug 9, 2021
carterkozak
added a commit
that referenced
this pull request
Aug 12, 2021
This has been excavated out and replaced by: https://github.com/palantir/witchcraft-java-logging#gradle-plugin The witchcraft-java-logging gradle plugin acts as a marker to avoid our silly sls-packaging class availability check. Revert "recommend witchcraft logging (#1863)" This reverts commit 0d8bce0.
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==COMMIT_MSG==
Recommend the Witchcraft logging plugin when the sls-packaging distribution plugin is detected
==COMMIT_MSG==