Disable intellij's ClassCanBeRecord inspection

[fawind]

Before this PR

When using JDK 17+, Intellij's ClassCanBeRecord inspection gets suggested for all classes with only final fields that get set through the constructor. However in many cases, this is not desired as this weakens the visibility of the fields by adding public getters. I would argue that for all classes that use dependency injection, this is not desired.

Example class which gets flagged:

class MyResource {
  private final Store store;
  private final OtherService otherService;

  MyResource(Store store, OtherService otherService) {
    this.store = store;
    this.otherService = otherService
  }
}

Given that this gets flagged in Intellij as a warning with the default action to automatically convert the class, I think its best to disable this inspection.

After this PR

==COMMIT_MSG==
Disable intellij's ClassCanBeRecord inspection
==COMMIT_MSG==

Possible downsides?

In some cases it might be desirable (e.g. data classes). But maybe we should handle this using an explicit error-prone check?

[changelog-app]

Generate changelog in changelog/@unreleased

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Disable intellij's ClassCanBeRecord inspection

Check the box to generate changelog(s)

• Generate changelog entry

[svc-autorelease]

Released 4.114.0