Safety propagation ignores immutables helpers #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example:
```
@Value.Immutable
interface Context {
AuthService authService();
// not a field, only a utility method
default BearerToken token() {
return authService().currentToken();
}
}
```
Generate changelog in
|
tpetracca
reviewed
Apr 28, 2022
...e-error-prone/src/test/java/com/palantir/baseline/errorprone/SafeLoggingPropagationTest.java
Show resolved
Hide resolved
tpetracca
reviewed
Apr 28, 2022
| } | ||
|
|
||
| @Test | ||
| void testIgnoresJsonIgnoreHelperMethod() throws Exception { |
There was a problem hiding this comment.
this test would have been an ignore even without the JsonIgnore annotation. Is it worth a version of this test that would actually propagate the method safety annotaiton to the class if the JsonIgnore wasn't there?
There was a problem hiding this comment.
I'll add another test with a jsonignored field, however we do want to include those in safety because they're included in the toString.
tpetracca
approved these changes
Apr 28, 2022
bulldozer-bot
bot
deleted the
ckozak/propagation_ignores_private_immutables_methods
branch
|
Released 4.121.0 |
This was referenced Apr 29, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Apr 29, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.121.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Safety propagation ignores utility methods on immutables definitions | palantir/gradle-baseline#2237 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example:
==COMMIT_MSG==
Safety propagation ignores utility methods on immutables definitions
==COMMIT_MSG==