Stream.collect safety no longer incorrectly includes map collectors #2264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Map collectors, unlike most others, doesn't collect the data from the stream into an element, rather acts in two steps: A `stream.map` for each key and value function, as well as a collect of the merged results. Thus, we cannot make assumptions about the output safety based on the inputs. In the future, this will be handled using the same functionality as `stream.map(func)`.
Generate changelog in
|
fawind
approved these changes
May 11, 2022
|
Released 4.131.0 |
This was referenced May 11, 2022
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
May 11, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.131.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Stream.collect safety no longer incorrectly includes map collectors | palantir/gradle-baseline#2264 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced May 11, 2022
This was referenced May 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map collectors, unlike most others, doesn't collect the data from
the stream into an element, rather acts in two steps: A
stream.mapfor each key and value function, as well as a collect of the merged
results. Thus, we cannot make assumptions about the output safety
based on the inputs. In the future, this will be handled using
the same functionality as
stream.map(func).==COMMIT_MSG==
Stream.collect safety no longer incorrectly includes map collectors
==COMMIT_MSG==
Possible downsides?
Sometimes the map collector result may be unsafe (e.g. Function.identity and similar), however in many cases we can get safety based on type information in the result. Best to produce high confidence results, as opposed to allowing developers to assume some are noise.