Fix javadoc when enable preview flag is added #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
approved these changes
Jul 29, 2022
|
Released 4.151.0 |
|
Sorry I didn't include a test for this first time round!! |
This was referenced Jul 29, 2022
Merged
This was referenced Jul 29, 2022
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Jul 30, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.151.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | javadoc tasks are now properly configured when `--enable-preview` is used | palantir/gradle-baseline#2338 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Jul 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
We'd successfully add the
-enable-previewflag to thejavadoctask, but since we don't have the-sourceor--releaseflags, it fails with the following:We did not have an automated test that actually invokes
javadoc, hence why this bug slipped in.After this PR
==COMMIT_MSG==
javadoc tasks are now properly configured when
--enable-previewis used==COMMIT_MSG==
We now have a failing test that runs javadoc, and the last commit fixes it!
Possible downsides?