Roll back nullaway+checkerframework for jdk15 support #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer release support 11 and 17, but do not support the now-sunset jdk-15.
Generate changelog in
|
carterkozak
commented
Sep 16, 2022
Comment on lines
+89
to
+97
| def 'compileJava succeeds when null-away finds no errors on jdk15'() { | ||
| when: | ||
| buildFile << standardBuildFile.replace('libraryTarget = 17', 'libraryTarget = 15') | ||
| file('src/main/java/com/palantir/test/Test.java') << validJavaFile | ||
|
|
||
| then: | ||
| BuildResult result = with('compileJava').build() | ||
| result.task(":compileJava").outcome == TaskOutcome.SUCCESS | ||
| } |
There was a problem hiding this comment.
This test fails without the change.
|
Released 4.168.0 |
This was referenced Sep 16, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Sep 16, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.168.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Roll back nullaway+checkerframework for jdk15 support | palantir/gradle-baseline#2389 | ## 4.169.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Exclude Spark UnusedStubClass from class uniqueness | palantir/gradle-baseline#2390 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer release support 11 and 17, but do not support the now-sunset jdk-15.
==COMMIT_MSG==
Roll back nullaway+checkerframework for jdk15 support
==COMMIT_MSG==
Possible downsides?
Unfortunately we can't use the latest release of checkerframework libs until folks have migrated away from jdk15 MTS builds.