lazily configure NullAway dependencies #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
commented
Sep 19, 2022
| private static void configureErrorProneOptions(Project project, Action<ErrorProneOptions> action) { | ||
| project.getTasks().withType(JavaCompile.class).configureEach(new Action<JavaCompile>() { | ||
| private static void configureErrorProneOptions(Project proj, Action<ErrorProneOptions> action) { | ||
| proj.afterEvaluate(new Action<Project>() { |
There was a problem hiding this comment.
This matches our internal plugin configuration
carterkozak
force-pushed
the
ckozak/configure_errorprone_deps
branch
from
33aed25 to
e8349c3
Compare
pkoenig10
approved these changes
Sep 19, 2022
|
Released 4.170.0 |
This was referenced Sep 19, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Sep 19, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.170.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | lazily configure NullAway dependencies to successfully apply NullAway without ordering issues | palantir/gradle-baseline#2393 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Plugin failed to apply in some cases
After this PR
==COMMIT_MSG==
lazily configure NullAway dependencies to successfully apply NullAway without ordering issues
==COMMIT_MSG==
Possible downsides?
Unable to repro the failure which prompted thisSolved