Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress test classes that are in a "tests" folder #243

Closed
wants to merge 1 commit into from

Conversation

tusharnarayan
Copy link

for example, integration tests that live in src/integrationTests/java

noticed because after #240, static imports in classes within my integrationTests folder were causing checkstyle violations - figured we want to make the s optional for test all suppression rules

@tusharnarayan
Copy link
Author

@uschi2000 and @iamdanfox for review

@iamdanfox
Copy link
Contributor

@tusharnarayan would you consider renaming your source set to integrationTest for consistency with the existing singular test one? It seems kinda preferrable to unify on singular names rather than supporting both singular and plural?

@tusharnarayan
Copy link
Author

yeah i poked around a couple projects first, seems like a number of folks are using integrationTests - i'm down to rename if that's something we want to standardize on

@iamdanfox
Copy link
Contributor

Cool, I think it makes sense to just match the existing singular noun approach and use src, test, integrationTest/integTest and ete rather than plurals

@iamdanfox iamdanfox closed this Feb 21, 2018
@tusharnarayan tusharnarayan deleted the patch-1 branch February 21, 2018 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants