Suggest avoiding default case in switch statements #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdanfox
reviewed
Dec 4, 2018
| @BugPattern( | ||
| name = "SwitchStatementDefaultCase", | ||
| category = Category.ONE_OFF, | ||
| link = "https://github.com/palantir/gradle-baseline#baseline-error-prone-checks", |
There was a problem hiding this comment.
Could you add a sentence or two to the README to flesh out the reasoning behind this a bit more (i.e. recommending to throw an unreachable exception)?
|
Thanks for implementing this @pkoenig10! |
|
@iamdanfox do you have any opposition to making this a warning? If not now, maybe in the future? |
iamdanfox
approved these changes
Dec 4, 2018
|
I think it's OK to run with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #480
A severity of
WARNINGis probably too strong for this check.