PathConvertingFileSystem converts FileStatus objects in-place

[rshkv]

Before this PR

The current implementation of PathConvertingFileSystem#toReturnFileStatus, the method that converts file statuses from the delegating file system, creates new FileStatus objects. This doesn't work with custom implementation of FileStatus.

After this PR

Convert file statuses from the delegating file status by setting the new path instead over creating a whole new object. I couldn't find an implementation of FileStatus that would be negatively affected by this. To the contrary: if file system implementations return custom file status implementation, the delegating file system should respect those and not return new statuses of a different type.

==COMMIT_MSG==
PathConvertingFileSystem renames paths without creating new FileStatus objects.
==COMMIT_MSG==

[changelog-app]

Generate changelog in changelog/@unreleased

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

PathConvertingFileSystem renames paths without creating new FileStatus objects.

Check the box to generate changelog(s)

• Generate changelog entry

[schlosna]

Is there a test case that covers the behavior we want here?

[rshkv]

Yeah, PathConvertingFileSystemTest covers the conversion here:

hadoop-crypto/hadoop-crypto/src/test/java/com/palantir/crypto2/hadoop/PathConvertingFileSystemTest.java

Lines 121 to 135 in d0853ab

	@Test
	public void listStatus() throws Exception {
	when(delegate.listStatus(DELEGATE_PATH)).thenReturn(new FileStatus[] {fileStatus(DELEGATE_PATH)});
	FileStatus[] fileStatuses = convertingFs.listStatus(PATH);
	assertThat(fileStatuses).containsExactly(fileStatus(RETURN_PATH));
	}
	@Test
	public void getFileStatus() throws Exception {
	when(delegate.getFileStatus(DELEGATE_PATH)).thenReturn(fileStatus(DELEGATE_PATH));
	FileStatus fileStatus = convertingFs.getFileStatus(PATH);
	assertThat(fileStatus).isEqualTo(fileStatus(RETURN_PATH));
	}

[rshkv]

Also testing e.g. the object reference felt too much like an implementation detail. But can add.

[rshkv]

On further thought testing the new behavior makes sense: added in 410ff78.

[svc-autorelease]

Released 3.4.0