Have metric-schema accept numeric Gauges only #1040
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gauges only work properly with Prometheus if they are numeric-typed, i.e. convertible to float64. To enforce this in Java, replace Gauge<?> with Gauge<? extends Number>.
Before this PR
Gauge declarations are untyped, allowing for any value type even though only numbers are legal.
After this PR
==COMMIT_MSG==
Gauges will only accept numeric types, matching the constraints of Prometheus (thus ensuring the Gauge
won't be silently dropped downstream).
==COMMIT_MSG==
Possible downsides?
Library consumers may need to fix bugs where gauges are returning
non-numeric types.