-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
broaden the requestTrace attachment accessor #1297
Conversation
Generate changelog in
|
59eae9c
to
6ca1d0f
Compare
@SuppressWarnings("unchecked") | ||
public static final AttachmentKey<Detached> REQUEST_DETACHED_TRACE = | ||
(AttachmentKey<Detached>) (AttachmentKey<?>) REQUEST_SPAN; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love exposing this directly since it allows the attachment to be removed, and we don't really expect anyone to do that. The risk is small, and this unblocks applying tracing to some additional libraries without consuming that functionality directly into tracing-undertow
. In particular WebSocketHttpExchange
wraps an HttpServerExchange
and exposes its attachments, but doesn't implement Attachable
or expose the underlying exchange directly.
Released 6.20.0 |
==COMMIT_MSG==
broaden the requestTrace attachment accessor
==COMMIT_MSG==
This allows us to pull the attachment value from one of the many types which wrap an HttpServerExchange and delegate to its attachments, for example
WebSocketHttpExchange
(not Attachable) andServerSentEventConnection
(Attachable).