Bugfix trailing-comma for new without parens (#2389)

[bugfix] `trailing-comma` no longer crashes on new without parentheses (e.g. `new Foo`)
palantir · Mar 25, 2017 · a3eaf5d · a3eaf5d
1 parent 13dec24
commit a3eaf5d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/src/rules/trailingCommaRule.ts b/src/rules/trailingCommaRule.ts
@@ -94,9 +94,13 @@ class TrailingCommaWalker extends Lint.AbstractWalker<Options> {
                 case ts.SyntaxKind.EnumDeclaration:
                     this.checkList((node as ts.EnumDeclaration).members, node.end);
                     break;
-                case ts.SyntaxKind.CallExpression:
                 case ts.SyntaxKind.NewExpression:
-                    this.checkList((node as ts.CallExpression | ts.NewExpression).arguments, node.end);
+                    if ((node as ts.NewExpression).arguments === undefined) {
+                        break;
+                    }
+                    // falls through
+                case ts.SyntaxKind.CallExpression:
+                    this.checkList((node as ts.CallExpression | ts.NewExpression).arguments!, node.end);
                     break;
                 case ts.SyntaxKind.ArrowFunction:
                 case ts.SyntaxKind.Constructor:

diff --git a/test/rules/trailing-comma/multiline-always/test.ts.fix b/test/rules/trailing-comma/multiline-always/test.ts.fix
@@ -544,3 +544,6 @@ export {
     foo,
     bar,
 };
+
+// don't crash
+new Foo
diff --git a/test/rules/trailing-comma/multiline-always/test.ts.lint b/test/rules/trailing-comma/multiline-always/test.ts.lint
@@ -573,3 +573,6 @@ export {
     bar
        ~nil [Missing trailing comma]
 };
+
+// don't crash
+new Foo
-Original file line number
+Diff line change
@@ Expand Up / @@ -544,3 +544,6 @@ export { @@
         foo,
         bar,
     };
+    // don't crash
+    new Foo