Remove ? from abstract format's params.

As noted in comments on #3838, these parameters in the interface definition should not have `?` as they are always passed to the implementation. Implementors should instead choose to _omit_ the args from their implementations if unused.
palantir · May 7, 2018 · ba646a1 · ba646a1
1 parent 76c2ece
commit ba646a1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/language/formatter/abstractFormatter.ts b/src/language/formatter/abstractFormatter.ts
@@ -20,7 +20,7 @@ import { IFormatter, IFormatterMetadata } from "./formatter";
 
 export abstract class AbstractFormatter implements IFormatter {
     public static metadata: IFormatterMetadata;
-    public abstract format(failures: RuleFailure[], fixes?: RuleFailure[], fileNames?: string[]): string;
+    public abstract format(failures: RuleFailure[], fixes: RuleFailure[], fileNames: string[]): string;
 
     protected sortFailures(failures: RuleFailure[]): RuleFailure[] {
         return failures.slice().sort(RuleFailure.compare);

diff --git a/src/language/formatter/formatter.ts b/src/language/formatter/formatter.ts
@@ -57,5 +57,5 @@ export interface IFormatter {
      * @param fixes Fixed linter failures. Available when the `--fix` argument is used on the command line
      * @param fileNames All of file paths that were linted
      */
-    format(failures: RuleFailure[], fixes?: RuleFailure[], fileNames?: string[]): string;
+    format(failures: RuleFailure[], fixes: RuleFailure[], fileNames: string[]): string;
 }