Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Mark RuleWalker, ProgramAwareRuleWalker, and ScopeAwareRuleWalker as deprecated #4298

Closed
JoshuaKGoldberg opened this issue Nov 16, 2018 · 1 comment · Fixed by #4413
Closed

Comments

@JoshuaKGoldberg
Copy link
Contributor

JoshuaKGoldberg commented Nov 16, 2018

Recapping #2522: RuleWalker-based rules are slow, so it's generally preferable to use applyWithFunction instead of applyWithWalker.

if folks shouldn't use RuleWalker, it would be good to actively encourage new PRs not to. TSLint could mark them as @deprecated in their doc comments and put // tslint:disable-next-line:deprecation with links to issue(s) tracking converting them to walk functions.

Edit: TwoThree thumbs up from over a month - marking as accepting PRs 😊

Nazanin1369 added a commit to Nazanin1369/tslint that referenced this issue Dec 26, 2018
@JoshuaKGoldberg JoshuaKGoldberg changed the title Mark RuleWalker and ScopeAwareRuleWalker as deprecated Mark RuleWalker, ProgramAwareRuleWalker, and ScopeAwareRuleWalker as deprecated Dec 26, 2018
Nazanin1369 added a commit to Nazanin1369/tslint that referenced this issue Dec 26, 2018
@adidahiya adidahiya added this to the 5.13.0 milestone Jan 10, 2019
@adidahiya
Copy link
Contributor

let's do this for 5.13.0. also need to update the relevant docs in docs/develop/custom-rules/index.md

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants