This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Added test names to VS Code console logs for ruleTestRunner #3458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because some of the logs are to `process.stdout`, the VS Code F5 test running just shows a lot of "Passed" messages. Not very informative. This adds a `folder > folder`-style descriptor for the test if running with `--verboseResultHandler`, which is passed by `launch.json`.
|
Per #3457 (comment), switched it to always use
|
ajafff
suggested changes
Nov 6, 2017
There was a problem hiding this comment.
This is probably the better way to solve this: microsoft/vscode#19750 (comment)
|
#3374 tries to get rid of all |
1 task
adidahiya
pushed a commit
that referenced
this pull request
Jan 9, 2018
HyphnKnight
pushed a commit
to HyphnKnight/tslint
that referenced
this pull request
Apr 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Because some of the logs are to
process.stdout, the VS Code F5 test running just shows a lot of "Passed" messages. Not very informative. This adds afolder > folder-style descriptor for the test if running with--verboseResultHandler, which is passed bylaunch.json.Is there anything you'd like reviewers to focus on?
Alternately, it could just print everything using the console instead of
process.stdout...?