feat: Conflict phpstan >1.10.54, currently rector is broken with latest phpstan

.github/workflows/functional_test__rector_examples.yml

@@ -46,7 +46,7 @@ jobs:
             -   name: Install Drupal Rector
                 run: |
                     cd ~/drupal
-                    composer require palantirnet/drupal-rector:@dev --no-progress
+                    composer require palantirnet/drupal-rector:@dev --no-progress --update-with-dependencies
             -   name: Install Drupal Rector Config
                 run: |
                     cd ~/drupal

composer.json

@@ -13,6 +13,10 @@
         "rector/rector": "~0.18.0",
         "webflo/drupal-finder": "^1.2"
     },
+    "conflict": {
+        "phpstan/phpstan": ">=1.10.55",
+        "rector/rector": ">=0.19"
+    },
     "license": "MIT",
     "authors": [
         {

config/drupal-8/drupal-8.2-deprecations.php

@@ -12,7 +12,7 @@
     });
     // https://www.drupal.org/node/2802569
     $rectorConfig->ruleWithConfiguration(FunctionToStaticRector::class, [
-        new \DrupalRector\Rector\ValueObject\FunctionToStaticConfiguration(
+        new DrupalRector\Rector\ValueObject\FunctionToStaticConfiguration(
             '8.2.0',
             'file_directory_os_temp',
             'Drupal\Component\FileSystem\FileSystem',

config/drupal-8/drupal-8.6-deprecations.php

@@ -10,7 +10,7 @@
     $rectorConfig->singleton(AddCommentService::class, function () {
         return new AddCommentService();
     });
-    $rectorConfig->ruleWithConfiguration(\DrupalRector\Drupal8\Rector\Deprecation\StaticToFunctionRector::class, [
+    $rectorConfig->ruleWithConfiguration(DrupalRector\Drupal8\Rector\Deprecation\StaticToFunctionRector::class, [
         // https://www.drupal.org/node/2850048
         new StaticToFunctionConfiguration('Drupal\Component\Utility\Unicode', 'strlen', 'mb_strlen'),
         // https://www.drupal.org/node/2850048

config/drupal-9/drupal-9.1-deprecations.php

@@ -42,7 +42,7 @@
     $rectorConfig->rule(AssertNoFieldByNameRector::class);
     $rectorConfig->rule(AssertFieldByIdRector::class);
 
-    $rectorConfig->ruleWithConfiguration(\DrupalRector\Drupal9\Rector\Deprecation\AssertLegacyTraitRector::class, [
+    $rectorConfig->ruleWithConfiguration(DrupalRector\Drupal9\Rector\Deprecation\AssertLegacyTraitRector::class, [
         new AssertLegacyTraitConfiguration('assertLinkByHref', 'linkByHrefExists'),
         new AssertLegacyTraitConfiguration('assertLink', 'linkExists'),
         new AssertLegacyTraitConfiguration('assertNoEscaped', 'assertNoEscaped'),

config/drupal-9/drupal-9.3-deprecations.php

@@ -33,9 +33,9 @@
     ]);
 
     // Change record: https://www.drupal.org/node/2940031
-    $rectorConfig->rule(\DrupalRector\Drupal9\Rector\Deprecation\FileCreateUrlRector::class);
-    $rectorConfig->rule(\DrupalRector\Drupal9\Rector\Deprecation\FileUrlTransformRelativeRector::class);
-    $rectorConfig->rule(\DrupalRector\Drupal9\Rector\Deprecation\FromUriRector::class);
+    $rectorConfig->rule(DrupalRector\Drupal9\Rector\Deprecation\FileCreateUrlRector::class);
+    $rectorConfig->rule(DrupalRector\Drupal9\Rector\Deprecation\FileUrlTransformRelativeRector::class);
+    $rectorConfig->rule(DrupalRector\Drupal9\Rector\Deprecation\FromUriRector::class);
 
     // Change record: https://www.drupal.org/node/3223520
     $rectorConfig->ruleWithConfiguration(FunctionToServiceRector::class, [

config/drupal-9/drupal-9.4-deprecations.php

@@ -4,5 +4,5 @@
 
 return static function (Rector\Config\RectorConfig $rectorConfig): void {
     // Change record https://www.drupal.org/node/3220952
-    $rectorConfig->rule(\DrupalRector\Drupal9\Rector\Deprecation\ModuleLoadRector::class);
+    $rectorConfig->rule(DrupalRector\Drupal9\Rector\Deprecation\ModuleLoadRector::class);
 };

phpstan-baseline.neon

@@ -50,6 +50,11 @@ parameters:
 			count: 1
 			path: src/Drupal8/Rector/Deprecation/EntityLoadRector.php
 
+		-
+			message: "#^Parameter \\#1 \\$items of class PhpParser\\\\Node\\\\Expr\\\\Array_ constructor expects array\\<PhpParser\\\\Node\\\\ArrayItem\\>, array\\<int, PhpParser\\\\Node\\\\Expr\\\\ArrayItem\\> given\\.$#"
+			count: 1
+			path: src/Drupal8/Rector/Deprecation/EntityLoadRector.php
+
 		-
 			message: "#^Access to an undefined property PhpParser\\\\Node\\\\Expr\\:\\:\\$expr\\.$#"
 			count: 2
@@ -109,3 +114,11 @@ parameters:
 			message: "#^Call to an undefined method PHPStan\\\\Type\\\\Type\\:\\:getValue\\(\\)\\.$#"
 			count: 1
 			path: src/Drupal9/Rector/Deprecation/ExtensionPathRector.php
+
+		-
+			message: """
+				#^Fetching deprecated class constant REMOVE_NODE of class PhpParser\\\\NodeTraverser\\:
+				Use NodeVisitor\\:\\:REMOVE_NODE instead\\.$#
+			"""
+			count: 1
+			path: src/Drupal9/Rector/Deprecation/PassRector.php

tests/src/Drupal8/Rector/Deprecation/FunctionalTestDefaultThemePropertyRector/config/configured_rule.php

@@ -5,5 +5,5 @@
 use Rector\Config\RectorConfig;
 
 return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(\DrupalRector\Drupal8\Rector\Deprecation\FunctionalTestDefaultThemePropertyRector::class);
+    $rectorConfig->rule(DrupalRector\Drupal8\Rector\Deprecation\FunctionalTestDefaultThemePropertyRector::class);
 };

tests/src/Drupal9/Rector/Property/ProtectedStaticModulesPropertyRector/config/configured_rule.php

@@ -5,5 +5,5 @@
 use Rector\Config\RectorConfig;
 
 return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(\DrupalRector\Drupal9\Rector\Property\ProtectedStaticModulesPropertyRector::class);
+    $rectorConfig->rule(DrupalRector\Drupal9\Rector\Property\ProtectedStaticModulesPropertyRector::class);
 };