Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent headers in modals #2505

Closed
LeXofLeviafan opened this issue Aug 25, 2024 · 0 comments · Fixed by #2509
Closed

Inconsistent headers in modals #2505

LeXofLeviafan opened this issue Aug 25, 2024 · 0 comments · Fixed by #2509

Comments

@LeXofLeviafan
Copy link
Contributor

Bootstrap4 modals have a minor bug, which is still present in the current version of the repo. Namely, both model/modals/edit.html and model/modals/create.html contain the following code in header_text block:

<h5 class="modal-title">{{ … }}</h5>

Meanwhile, model/modals/details.html contains the following instead:

<h3>{{ … }}</h3>

…Which as you might guess results in different styling:
edit header
view header

LeXofLeviafan added a commit to LeXofLeviafan/flask-admin that referenced this issue Aug 27, 2024
samuelhwilliams added a commit that referenced this issue Aug 30, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant