prevent validators from getting inserted twice #1099
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1094
When
kwargs
inconvert()
is updated withfield_args
(reallyself.form_args
), only a referenced to mutable objects inself.form_args
are copied. So, modifyingkwargs
can also modify mutable objects in the overriddenself.form_args
. Validators likeUnique
will be added to self.form_args once when the edit form is created, then duplicated when the create form is created.The solution is to create a deepcopy of
field_args
to prevent the rest of that code from modifyingself.form_args
.Also submitted a pull request to wtf-peewee here: coleifer/wtf-peewee#30