Fixes #2406: Multiple requests are sent when opening create, edit, and detail modals due to repetitive load of bs4_modal.js
#2407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irtimir
changed the title
|
@irtimir @hasansezertasan Do we have information when this will be merged? |
Hey, I forgot about this issue, I just made changes after the review and hope this fix will be merged as soon as possible. |
irtimir
force-pushed
the
modals-multi-requests
branch
from
21fc4c0 to
2fbdabc
Compare
|
@hasansezertasan let's merge this if everything looks good? |
Let me check this once more 👍. |
|
@davidism, @samuelhwilliams, it looks good to me. I tried it with my hasansezertasan/not-just-a-todo-app project, works very well 🚀. I would approve this PR but, I don't have the permission to do so 😞. |
18 tasks
hasansezertasan
approved these changes
Jul 17, 2024
hasansezertasan
changed the title
bs4_modal.js
samuelhwilliams
approved these changes
Jul 17, 2024
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script tags that load
bs4_modal.jsintemplates/bootstrap4/admin/model/modals/create.html,templates/bootstrap4/admin/model/modals/edit.html, andtemplates/bootstrap4/admin/model/modals/details.htmltemplate files are removed.Fix: #2406