Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES+IT translations for username change & recovery #1069

Merged
merged 2 commits into from
Feb 8, 2025

Conversation

gissimo
Copy link
Contributor

@gissimo gissimo commented Feb 7, 2025

No description provided.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (ca15fde) to head (24d8515).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1069   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files          39       39           
  Lines        4974     4974           
=======================================
  Hits         4898     4898           
  Misses         76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwag956
Copy link
Collaborator

jwag956 commented Feb 7, 2025

Thanks - looks like there is a new mypy.... I will work on fixing that.

Also - I have (almost done!) some changes to templates (mostly email templates) that could affect some of your translations. I am just about to ship 5.6 - so this is great timing.
How about this:

  1. I will fix mypy
  2. I will merge your PR assuming no other issues
  3. I will merge my PR with some new translations
  4. I will ask you to give the new translations a once-over before I ship 5.6

Sound good?

@gissimo
Copy link
Contributor Author

gissimo commented Feb 7, 2025

Sounds great! Ping me when it's time to translate.

@jwag956 jwag956 merged commit 60bd341 into pallets-eco:main Feb 8, 2025
18 checks passed
@jwag956
Copy link
Collaborator

jwag956 commented Feb 8, 2025

Ok - translate away! Note that a bunch of changes are simply 'two factor' -> 'two-factor' - which might not even matter in other languages - however babel will throw out existing translations (sigh).

Thanks!

@gissimo
Copy link
Contributor Author

gissimo commented Feb 8, 2025

Done! Thanks for your great work! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants