Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pytest, test dependency versions #363

Closed
4 tasks done
davidism opened this issue Dec 11, 2015 · 4 comments
Closed
4 tasks done

Use pytest, test dependency versions #363

davidism opened this issue Dec 11, 2015 · 4 comments
Labels

Comments

@davidism
Copy link
Member

davidism commented Dec 11, 2015

Flask converted, we should too. They also test at the minimal, current, and development versions of their dependencies. I don't think we need to go development, but we definitely need to test at SQLAlchemy==0.8.

  • convert to pytest
  • split tests into multiple files
  • add tests at minimal dependencies to tox
  • adjust travis to use new test targets
@davidism
Copy link
Member Author

davidism commented Apr 9, 2016

added tox/travis envs in #388

@davidism davidism added the tests label Jan 15, 2017
@thrawny
Copy link
Contributor

thrawny commented May 13, 2017

Are looking for help with converting to pytest? I would like to help out.

@davidism
Copy link
Member Author

davidism commented May 13, 2017

@thrawny yes, that would be a big help! Some things I'd like to do:

  • split the tests into different files instead of one big one
  • use flat functions instead of classes
  • use fixtures where appropriate

Ultimately, I'd like to rewrite the whole test suite with consistency and coverage in mind, but you don't have to go that far. You can see Flask-WTF's test suite as an example, I rewrote that a while ago: https://github.com/lepture/flask-wtf/tree/master/tests

@thrawny
Copy link
Contributor

thrawny commented May 13, 2017

@davidism Great! Thanks for the input. Will start working on it then.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

2 participants