Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up tests, more thorough version testing #388

Merged
merged 1 commit into from
Apr 9, 2016
Merged

Conversation

davidism
Copy link
Member

@davidism davidism commented Apr 9, 2016

  • SQLALCHEMY_ENGINE isn't a config key, so the default sqlite:// was being used.
  • SQLALCHEMY_DATABASE_URI defaults to sqlite:// anyway, so just remove all these configs
  • CustomQueryClassTestCase wasn't registered
  • CustomQueryClassTestCase.test_dont_override_model_default wasn't testing the right thing, and was also failing
  • CustomModelClassTestCase wasn't registered
  • SQLite can have multiple in-memory databases for binds, don't need to create/remove files
  • Flask lowest tests against blinker==1.0, which doesn't have connected_to, replace with connect and disconnect
  • import flask_sqlalchemy as sqlalchemy is a confusing alias, used fsa instead
  • added "lowest" and "current" tox envs for testing dependency versions
  • use pytest as the test runner

* SQLALCHEMY_ENGINE isn't a config key
* SQLALCHEMY_DATABASE_URI defaults to sqlite://
* not all TestCases registered, some fail
* flask_sqlalchemy is aliased to sqlalchemy, confusing
* tox with min and current versions
@davidism davidism self-assigned this Apr 9, 2016
@davidism davidism merged commit a7eae3c into master Apr 9, 2016
@davidism davidism deleted the test-cleanup branch April 9, 2016 23:43
@davidism
Copy link
Member Author

davidism commented Apr 9, 2016

Ignore the failed ci build, I think it got confused between the initial push and the pr. It does pass: https://travis-ci.org/mitsuhiko/flask-sqlalchemy/builds/121980819.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant