Clean up tests, more thorough version testing #388
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLALCHEMY_ENGINE
isn't a config key, so the defaultsqlite://
was being used.SQLALCHEMY_DATABASE_URI
defaults tosqlite://
anyway, so just remove all these configsCustomQueryClassTestCase
wasn't registeredCustomQueryClassTestCase.test_dont_override_model_default
wasn't testing the right thing, and was also failingCustomModelClassTestCase
wasn't registeredconnected_to
, replace withconnect
anddisconnect
import flask_sqlalchemy as sqlalchemy
is a confusing alias, usedfsa
instead