Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect type from flag_value #1913

Merged
merged 1 commit into from
May 19, 2021
Merged

detect type from flag_value #1913

merged 1 commit into from
May 19, 2021

Conversation

davidism
Copy link
Member

If type is not given and the option is a flag, the type is detected from flag_value instead of falling back to STRING. This works even if default=True is given for feature flags, which simplifies convert_type a bit.

For 8.1, a further change to consider is for convert_type to return UNPROCESSED instead of STRING if the type was guessed from the default value. In that case, what should really happen is that a custom type should have been provided that would recognize/return the value in default, but converting it to STRING isn't correct either.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism added the f:parameters feature: input parameter types label May 19, 2021
@davidism davidism added this to the 8.0.1 milestone May 19, 2021
@davidism davidism merged commit ba9bb3c into 8.0.x May 19, 2021
@davidism davidism deleted the flag_value-type branch May 19, 2021 04:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
f:parameters feature: input parameter types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant