Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
type
is not given and the option is a flag, the type is detected fromflag_value
instead of falling back toSTRING
. This works even ifdefault=True
is given for feature flags, which simplifiesconvert_type
a bit.For 8.1, a further change to consider is for
convert_type
to returnUNPROCESSED
instead ofSTRING
if the type was guessed from the default value. In that case, what should really happen is that a customtype
should have been provided that would recognize/return the value indefault
, but converting it toSTRING
isn't correct either.Checklist:
CHANGES.rst
summarizing the change and linking to the issue... versionchanged::
entries in any relevant code docs.pre-commit
hooks and fix any issues.pytest
andtox
, no tests failed.