-
-
Notifications
You must be signed in to change notification settings - Fork 16.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation to reflect change in Gunicorn 20 #3421
Conversation
Gunicorn 20.0.0 no longer supports the factory pattern. A simple change to the documentation will prevent users from trying this method Here is the github issue regarding the change: benoitc/gunicorn#2159
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you shouldn't have an app instance there, I'd rather use myproject.wsgi:app
instead.
also, I'd rather see gunicorn add explicit support for calling an app factory. |
I agree with this, but it seems as if the plan is to deprecate this feature. |
I can't get this pattern to work on my project. Setting a variable to equal the return of the app factory is working. How does the "wsgi" call fit in here? |
you add a wsgi.py that imports and calls your app factory |
I agree with the suggestions. Having a separate module that calls the factory and exposes the result is a good way to do this. |
Looks good to me. |
Given that benoitc/gunicorn#2178 is slated for 20.0.1 and adds this functionality back, I'm going to close this. Thanks for working on it. |
Gunicorn 20.0.0 no longer supports the factory pattern.
A simple change to the documentation will prevent users from trying this method
Here is the github issue regarding the change:
benoitc/gunicorn#2159