send_file doesn't allow StringIO #3435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidism
force-pushed
the
send-file-text
branch
from
f2d04ab to
980168d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3358
Due to the way
send_fileworks, passing a text mode file-like object, such asio.StringIOin Python 3, would respond with 200 OK and an empty file, while printing a traceback to the terminal. Even in Python 2, this only worked by accident, and would probably fail if given aStringIO.StringIOobject with Unicode data that did not encode with the system encoding. It appearssend_filewas only intended to work with binary mode data.Now, if the object is an instance of
io.TextIOBaseit raises aValueError. This doesn't help for file-like objects that don't use theioABCs (including Python 2), but it should cover most cases.