Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subscribing topics with wildcards #1

Merged
merged 8 commits into from
Sep 27, 2022
Merged

Conversation

atimin
Copy link
Member

@atimin atimin commented Sep 27, 2022

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CHANGELOG.md have been updated (for bug fixes / features / docs)

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Topics like /drift/# didn't work.

What is the new behavior?

Fix parsing and add tests for them.

Does this PR introduce a breaking change?

No

Other information:

@atimin atimin changed the title Fix wildcard topics Fix subscribing topics with wildcards Sep 27, 2022
pkg/drift_mqtt/client.py Outdated Show resolved Hide resolved
@aschenbecherwespe aschenbecherwespe merged commit 293ef63 into develop Sep 27, 2022
@atimin atimin deleted the fix-wildcards branch April 28, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants