Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement is_offsetlike #18823

Merged
merged 4 commits into from
Dec 19, 2017
Merged

implement is_offsetlike #18823

merged 4 commits into from
Dec 19, 2017

Conversation

jbrockmendel
Copy link
Member

This is a subset of #18817 that just implements is_offsetlike in dtypes.common (plus a nicer docstring). This needs to be implemented before some fixes can be made in indexes.datetimelike, so is worth separating from the more difficult bits of 18817.

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Returns
-------
boolean : Whether the object is a DateOffset or listlike of DatetOffsets
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add some examples

@jreback jreback added the Frequency DateOffsets label Dec 18, 2017
@codecov
Copy link

codecov bot commented Dec 19, 2017

Codecov Report

Merging #18823 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18823      +/-   ##
==========================================
- Coverage   91.64%   91.62%   -0.02%     
==========================================
  Files         154      154              
  Lines       51401    51408       +7     
==========================================
- Hits        47106    47104       -2     
- Misses       4295     4304       +9
Flag Coverage Δ
#multiple 89.49% <100%> (ø) ⬆️
#single 40.83% <70%> (-0.13%) ⬇️
Impacted Files Coverage Δ
pandas/core/ops.py 91.69% <100%> (-0.09%) ⬇️
pandas/core/dtypes/common.py 94.54% <100%> (+0.08%) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.68% <0%> (-0.11%) ⬇️
pandas/core/groupby.py 92.07% <0%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a0ee19...0a97780. Read the comment docs.

@jreback jreback added this to the 0.22.0 milestone Dec 19, 2017
@jreback jreback merged commit 6747ab5 into pandas-dev:master Dec 19, 2017
@jreback
Copy link
Contributor

jreback commented Dec 19, 2017

thanks!

@jbrockmendel jbrockmendel deleted the offsetlike branch February 11, 2018 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants