-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Drop Python 3.5 support #29212
Merged
Merged
CI: Drop Python 3.5 support #29212
Changes from 7 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
83a41e6
CI: Drop Python 3.5 support
datapythonista e0dd3b3
Updating documentation
datapythonista 74f0cc4
Removing PY35 compatibility stuff, and other updates
datapythonista da1a24f
Fixing test in Mac
datapythonista fca2531
Fix typo in previous commit
datapythonista 50a18ad
Restoring build with the minimum versions of dependencies, but for py…
datapythonista 92cce08
Pinning to Python 3.6.0
datapythonista bb1b53d
Fixing black error, moving dependency to conda
datapythonista 4bbb571
Removing comment about py35
datapythonista ad93f0a
xfailing for the right reason (dateutil version)
datapythonista 29e59ec
Better fix for the xfail in dateutil < 2.7.0
datapythonista 0648171
Merge remote-tracking branch 'upstream/master' into py35
datapythonista 2b1abca
Temporary running tests in Python 3.5 to see if 'only integer scalar …
datapythonista ddbd726
Merge remote-tracking branch 'upstream/master' into py35
datapythonista df468bf
Merge branch 'py35' of github.com:datapythonista/pandas into py35
datapythonista eebaec9
Restoring minimal versions build to py36
datapythonista 4c0a066
Requiring 3.6.1 (3.6 seems to have a bug failing our tests)
datapythonista ad08687
Merge remote-tracking branch 'upstream/master' into py35
datapythonista File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,6 @@ | |
import sys | ||
import warnings | ||
|
||
PY35 = sys.version_info[:2] == (3, 5) | ||
PY36 = sys.version_info >= (3, 6) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can remove this entirely in a followup I think (by-definition PY36 will always be true) |
||
PY37 = sys.version_info >= (3, 7) | ||
PY38 = sys.version_info >= (3, 8) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -573,8 +573,6 @@ def test_agg_with_one_lambda(self): | |
|
||
# sort for 35 and earlier | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can remove |
||
columns = ["height_sqr_min", "height_max", "weight_max"] | ||
if compat.PY35: | ||
columns = ["height_max", "height_sqr_min", "weight_max"] | ||
expected = pd.DataFrame( | ||
{ | ||
"height_sqr_min": [82.81, 36.00], | ||
|
@@ -613,22 +611,13 @@ def test_agg_multiple_lambda(self): | |
"weight": [7.9, 7.5, 9.9, 198.0], | ||
} | ||
) | ||
# sort for 35 and earlier | ||
columns = [ | ||
"height_sqr_min", | ||
"height_max", | ||
"weight_max", | ||
"height_max_2", | ||
"weight_min", | ||
] | ||
if compat.PY35: | ||
columns = [ | ||
"height_max", | ||
"height_max_2", | ||
"height_sqr_min", | ||
"weight_max", | ||
"weight_min", | ||
] | ||
expected = pd.DataFrame( | ||
{ | ||
"height_sqr_min": [82.81, 36.00], | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be done as a follow up but not sure why this minimum is pinned to a beta, and I couldn't find anything in our docs for it. Probably safe to move to 1.0.1 which is available on conda