-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Fix IPython Tab Completion test async warning #30689
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jreback
requested changes
Jan 4, 2020
jreback
requested changes
Jan 4, 2020
jreback
approved these changes
Jan 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
@@ -251,3 +252,13 @@ def new_func(*args, **kwargs): | |||
assert flist2 == flist | |||
|
|||
return new_func | |||
|
|||
|
|||
def async_mark(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in a future PR can you type & add a doc-string
thanks @alimcmaster1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Output-Formatting
__repr__ of pandas objects, to_string
Testing
pandas testing functions or related to the test suite
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes Warnings from IPython tab completion tests #29070
passes
black pandas
passes
git diff upstream/master -u -- "*.py" | flake8 --diff
New PR since Correcting Warnings from IPython tab completion tests with async tests #29087 went stale