Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix IPython Tab Completion test async warning #30689

Merged
merged 9 commits into from
Jan 4, 2020

Conversation

alimcmaster1
Copy link
Member

@alimcmaster1 alimcmaster1 added Output-Formatting __repr__ of pandas objects, to_string Testing pandas testing functions or related to the test suite labels Jan 4, 2020
pandas/conftest.py Outdated Show resolved Hide resolved
pandas/tests/arrays/categorical/test_warnings.py Outdated Show resolved Hide resolved
pandas/conftest.py Outdated Show resolved Hide resolved
@alimcmaster1 alimcmaster1 marked this pull request as ready for review January 4, 2020 19:25
@jreback jreback added this to the 1.0 milestone Jan 4, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@@ -251,3 +252,13 @@ def new_func(*args, **kwargs):
assert flist2 == flist

return new_func


def async_mark():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in a future PR can you type & add a doc-string

@jreback jreback merged commit f9e524c into pandas-dev:master Jan 4, 2020
@jreback
Copy link
Contributor

jreback commented Jan 4, 2020

thanks @alimcmaster1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Output-Formatting __repr__ of pandas objects, to_string Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings from IPython tab completion tests
2 participants