CLN: Removed unused variable #32458
Closed
CLN: Removed unused variable #32458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Mar 5, 2020
|
|
||
| i = 0 | ||
| for start, stop in slices: | ||
| for diff in range(start, stop): | ||
| res_view[i] = diff |
There was a problem hiding this comment.
this is equivalent to setting result[i] = diff. my guess is doing it like with the memoryview is intended for perf
There was a problem hiding this comment.
I see, the CI is not passing which is a clear sign that this is important.
Now all that I am wondering is how to get rid of that warnings during compilation.
There was a problem hiding this comment.
Yea the warnings here are really the big blocker for #32163 . If you find a solution that would be huge!
|
@MomIsBestFriend we have a rather large queue atm so closing this one since I don't think would go forward with it anyway, but if you see a way to get the warnings out of this function would love a separate PR for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't see the reason for
res_viewto exist, the CI should tell me if I am wrong.Also this is removing one warning when compiling
pandas/_libs/internals.pyxThis is the warning that is removing: