Change default of float_precision for read_csv and read_table to "high" #36228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If there is no performance difference should we not just get rid of the legacy parsing altogether? |
My only concern here is that maybe someone has code that inadvertently depends on it, so we have to keep it in there for some form of compatibility. I do think we could deprecate the legacy parsing |
|
yep that sounds fine to leave th option just update the doc string to indicate |
Dr-Irv
commented
Sep 9, 2020
|
@jreback added the check for an invalid |
jreback
approved these changes
Sep 13, 2020
| @@ -2299,6 +2299,7 @@ def TextParser(*args, **kwds): | |||
| values. The options are None for the ordinary converter, | |||
| 'high' for the high-precision converter, and 'round_trip' for the | |||
| round-trip converter. | |||
| .. versionchanged:: 1.2 | |||
There was a problem hiding this comment.
check that tis renders ok, I think need a blank line after
5 tasks
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
3 tasks
Open
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests/io/parser/test_c_parser.pyto make sure all 4 options are testedtests/io/parser/test_c_parser.py:test_high_is_defaultblack pandasgit diff upstream/master -u -- "*.py" | flake8 --diffSee discussion at bottom of #36149 for the performance tests. Added
float_precision="legacy"so people can pick up the old parser. Can't change default to "high" because of incompatibility with python parser