Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: Only enable -Werror in the CI jobs #38087

Merged
merged 5 commits into from
Nov 27, 2020
Merged

BLD: Only enable -Werror in the CI jobs #38087

merged 5 commits into from
Nov 27, 2020

Conversation

xhochy
Copy link
Contributor

@xhochy xhochy commented Nov 26, 2020 •
edited by jreback
Loading

closes #33315
closes #33314

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@xhochy
Copy link
Contributor Author

xhochy commented Nov 26, 2020

In which whatsnew section should this go? Bug fixes - other?

@jorisvandenbossche
Copy link
Member

Thanks! "Bug fixes - other" is fine for me
(in pandas 1.0.0, we had a "build changes" section (https://pandas.pydata.org/docs/whatsnew/v1.0.0.html#build-changes), but that was a more relevant change, related to pyproject.toml)

@jorisvandenbossche jorisvandenbossche added this to the 1.2 milestone Nov 26, 2020
@jorisvandenbossche jorisvandenbossche changed the title Only enable -Werror in the CI jobs BLD: Only enable -Werror in the CI jobs Nov 26, 2020
jreback
jreback requested changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very minor comment, lgtm

@jreback jreback added the Build Library building on various platforms label Nov 26, 2020
@jreback
Copy link
Contributor

jreback commented Nov 26, 2020

also not averse to do this for 1.1.5 as well.

@simonjayhawkins
Copy link
Member

also not averse to do this for 1.1.5 as well.

sure. however not an issue on MacPython for 1.1.5. Is causing issues with 1.2 though. see #37784 (comment)

MacPython/pandas-wheels#112 my not be needed with this change.

@jreback
Copy link
Contributor

jreback commented Nov 26, 2020

also not averse to do this for 1.1.5 as well.

sure. however not an issue on MacPython for 1.1.5. Is causing issues with 1.2 though. see #37784 (comment)

MacPython/pandas-wheels#112 my not be needed with this change.

interesting ok, then fine not to backport.

@simonjayhawkins
Copy link
Member

interesting ok, then fine not to backport.

it's not causing us issues, but i'm ok with backporting if it could be beneficial to others

@xhochy
Copy link
Contributor Author

xhochy commented Nov 26, 2020

interesting ok, then fine not to backport.

it's not causing us issues, but i'm ok with backporting if it could be beneficial to others

It would be helpful for the conda packages on macOS

@jreback jreback modified the milestones: 1.2, 1.1.5 Nov 26, 2020
jreback
jreback reviewed Nov 26, 2020
View reviewed changes
doc/source/whatsnew/v1.2.0.rst Outdated
@@ -766,6 +766,7 @@ Other
- Bug in :meth:`Index.union` behaving differently depending on whether operand is an :class:`Index` or other list-like (:issue:`36384`)
- Passing an array with 2 or more dimensions to the :class:`Series` constructor now raises the more specific ``ValueError`` rather than a bare ``Exception`` (:issue:`35744`)
- Bug in ``dir`` where ``dir(obj)`` wouldn't show attributes defined on the instance for pandas objects (:issue:`37173`)
- Only set ``-Werror`` as a compiler flag in the CI jobs (:issue:`33315`, :issue:`33314`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok happy to backport, can you move to 1.1.5 whatnew

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you'd move the note, pls ping on green (might be a while, merged a lot of things today :->)

@simonjayhawkins
Copy link
Member

all green

@jreback
Copy link
Contributor

jreback commented Nov 26, 2020

this needs the note moved to 1.1.5

@simonjayhawkins
Copy link
Member

test failure unrelated

=========================== short test summary info ============================
FAILED pandas/tests/plotting/test_misc.py::TestDataFramePlots::test_scatter_matrix_axis
= 1 failed, 143660 passed, 3518 skipped, 1408 xfailed, 14 warnings in 1846.77s (0:30:46) =

@jorisvandenbossche jorisvandenbossche merged commit 003c4a7 into pandas-dev:master Nov 27, 2020
@jorisvandenbossche
Copy link
Member

Thanks @xhochy !

@simonjayhawkins
Copy link
Member

@meeseeksdev backport 1.1.x

@meeseeksmachine meeseeksmachine mentioned this pull request Nov 27, 2020
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Nov 27, 2020
@xhochy @meeseeksmachine
Backport PR pandas-dev#38087: BLD: Only enable -Werror in the CI jobs
3bcb3cd
simonjayhawkins pushed a commit that referenced this pull request Nov 27, 2020
@meeseeksmachine @xhochy
Backport PR #38087: BLD: Only enable -Werror in the CI jobs (#38124)
45c1016 
Co-authored-by: Uwe L. Korn <[email protected]>
@xhochy xhochy deleted the keep-werror-on-ci branch December 1, 2020 16:41
@WillAyd WillAyd mentioned this pull request Nov 16, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Build Library building on various platforms
Projects
None yet
Milestone
1.1.5
Development

Successfully merging this pull request may close these issues.

Remove -Werror from setup.py BUG: clang-9: error: -Wl,-export_dynamic: 'linker' input unused (OSX)
4 participants
@xhochy @jorisvandenbossche @jreback @simonjayhawkins