Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: add test_ffill_with_string_column #40557

Merged
merged 8 commits into from
May 13, 2021
Merged

TST: add test_ffill_with_string_column #40557

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6c4ec55
Merge pull request #1 from pandas-dev/master
shiv-io Mar 20, 2021
e96d0d4
Add test
shiv-io Mar 21, 2021
e633c2a
Parameterize test to test bfill and ffill
shiv-io Apr 17, 2021
c723e8c
Update function name
shiv-io Apr 17, 2021
c4902e6
Clean up result assignment
shiv-io May 9, 2021
31c9312
Parameterize expected dataframe
shiv-io May 9, 2021
4e23007
Add test function parameter
shiv-io May 9, 2021
ca4acb8
Merge branch 'pandas-dev:master' into tst-gh-40250
shiv-io May 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pandas/tests/groupby/test_missing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,17 @@ def test_ffill_missing_arguments():
df.groupby("b").fillna()


def test_ffill_with_string_column():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to test_ffill_with_string_dtype

Copy link
Contributor Author

@shiv-io shiv-io Apr 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it made sense to rename to test_fillna_with_string_dtype since I have now parameterized the test to test both ffill and bfill.

# GH 40250
result = (
DataFrame({"a": pd.array([None, "a"], dtype="string"), "b": [0, 0]})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change the example so it also fills a forward value (e.g. make the input '[None, "a", None]'

.groupby("b")
.ffill()
)
expected = DataFrame({"a": pd.array([None, "a"], dtype="string")})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would also not object to a parameterized version which tests bfill as well.

tm.assert_frame_equal(result, expected)


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may have a similar example with object dtype, if you can co-locate, alternatively can parameterize on the dtype as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after #41343 is merged, can use the any_string_dtype fixture

def test_fill_consistency():

# GH9221
Expand Down