Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMPAT: add back dummy CategoricalBlock class #40582

Merged
merged 3 commits into from
Mar 23, 2021
Merged

COMPAT: add back dummy CategoricalBlock class #40582

merged 3 commits into from
Mar 23, 2021

Conversation

jorisvandenbossche
Copy link
Member

See #40226 (comment)

@jbrockmendel this is unfortunate, but short term I think we need to keep the CategoricalBlock class. I am not directly sure what would be the best way to actually deprecate this.

@jorisvandenbossche jorisvandenbossche added Internals Related to non-user accessible pandas implementation Compat pandas objects compatability with Numpy or Python functions Categorical Categorical Data Type labels Mar 23, 2021
@jorisvandenbossche jorisvandenbossche added this to the 1.3 milestone Mar 23, 2021
@jbrockmendel
Copy link
Member

I am not directly sure what would be the best way to actually deprecate this.

Could keep the deprecation in internals.__init__.__getattr__

@jorisvandenbossche
Copy link
Member Author

Ah, yes, that's a good idea. Since we don't use that import path ourselves, we can still deprecate accessing the class that way.

jbrockmendel
jbrockmendel approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreback
Copy link
Contributor

jreback commented Mar 23, 2021

what is the user of this actual class? pyarrow?

@jorisvandenbossche
Copy link
Member Author

yes, pyarrow uses isinstance(block, CategoricalBlock) right now

@jreback
Copy link
Contributor

jreback commented Mar 23, 2021

why didn't this break the CI? (the original change)

@jorisvandenbossche
Copy link
Member Author

Because we don't have full coverage of pyarrow functionality in our tests (and we don't run the full pyarrow test suite), there were only a few failures in the pyarrow CI.

@jreback
Copy link
Contributor

jreback commented Mar 23, 2021

Because we don't have full coverage of pyarrow functionality in our tests (and we don't run the full pyarrow test suite), there were only a few failures in the pyarrow CI.

ahh ok. is it possible to add something that exercises internals? (not blocking here)

@jreback jreback merged commit 79f1801 into pandas-dev:master Mar 23, 2021
@jorisvandenbossche jorisvandenbossche deleted the categoricalblock branch March 23, 2021 16:29
vladu pushed a commit to vladu/pandas that referenced this pull request Apr 5, 2021
@jorisvandenbossche @vladu
COMPAT: add back dummy CategoricalBlock class (pandas-dev#40582)
7d88a31
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@jorisvandenbossche @JulianWgs
COMPAT: add back dummy CategoricalBlock class (pandas-dev#40582)
882d1f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

Assignees
No one assigned
Labels
Categorical Categorical Data Type Compat pandas objects compatability with Numpy or Python functions Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jorisvandenbossche @jbrockmendel @jreback