-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REF: remove DatetimeBlock, TimeDeltaBlock #40614
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Similarly as #40527, we should maybe first deprecate those Block classes before removing them? |
why? what is using them |
In pyarrow, we are explicitly using CategoricalBlock, DatetimeTZBlock, ObjectBlock and ExtensionBlock. So not DatetimeBlock or TimedeltaBlock, but that's only one data point, and given that we are already using many of the block classes, I think we should be careful with removing any of them. |
These are things that downstream libraries shouldnt be using. If this breaks something for someone we can deprecate like we did for CategoricalBlock, but I don't see any reason to do so pre-emptively, given that no one chimed in in #40226 saying they use these. |
i agree with @jbrockmendel if something downstream is breaking that we can re add and depreciate |
sits on top of #40456