-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PERF: put BlockManager constructor in cython #40842
Conversation
can you merge master |
any perf on this vs master (now that the ndarray stuff is merged)? (ideally put the relevant timeits in the cython code, that is a great idea generally) |
On the benchmark I've been using for these im seeing about a 4% gain (though the worst performance had a 0.2% slowdown). The big win I'm expecting comes in the next step, which puts BlockManager.get_slice in cython, which allows us to chain together several no-longer-python calls |
rebased + green |
Just measured the branch after this (that implements BlockManager.get_slice in cython) and that gets a 15% improvement. |
PERF: put BlockManager constructor in cython (pandas-dev#40842)
As I have mentioned before (eg on the mailing list, in #40263), this benchmark is basically useless / unrealistic. |
No idea why mypy started complaining about the io.parsers stuff