-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REF: names no longer needed in _form_blocks, create_block_manager_from_arrays #43114
Conversation
yeah we think pyarrow (and maybe fastparquet) uses this internal api? |
yah will have to see when the time comes |
failure is codecov looking on github for external uses of create_block_manager_from_arrays and mostly just seeing it in pandas forks |
kk great. lookign forward to code deletions. |
I don't think that pyarrow or fastparquet use this (in any case pyarrow doesn't, xref #40226). |
great, let's rip it out and see if anyone complains |
cc @TomAugspurger looks like we kept create_block_manager_from_arrays in the internals namespace for dask. Is it still needed? |
Looks like that was just the other function create_block_manager_from_blocks |
Ah, yes, dask/partd uses |
Two follow-ups after this:
4) remove no-longer-needed checks in no-longer-pseudo-public create_block_manager_from_column_arrays
5) deprecate pseudo-public create_block_manager_from_arrays