DEPS: Bump optional dependencies #55524
Conversation
| # GH 54239, 54287 | ||
| pa = pytest.importorskip("pyarrow", "11.0.0") | ||
| import pyarrow.compute as pc | ||
|
|
||
| if is_platform_windows() and is_ci_environment(): |
There was a problem hiding this comment.
use _require_timezone_database?
There was a problem hiding this comment.
Yeah can do this in a follow up. It's current centralized in test_arrow.py
| - openpyxl>=3.1.0 | ||
| # Doesn't install well with pyarrow | ||
| # https://github.com/pandas-dev/pandas/issues/55525 | ||
| # - pandas-gbq>=0.19.0 |
There was a problem hiding this comment.
Does this not affect test coverage?
There was a problem hiding this comment.
Not really. There's only one unit test that just attempts to import this package which doesn't seem useful
|
I think this looks good. Is the 1 year dependency minimum new? That was 2 in the past right? |
I bumped our optional dependencies to a 1 year min last time #52552. Our required ones usually follow 2 |
| "pymysql": "1.0.2", | ||
| "pyarrow": "7.0.0", | ||
| "pyreadstat": "1.1.5", | ||
| "pyarrow": "10.0.1", |
There was a problem hiding this comment.
FWIW, the pyarrow PDEP said "When the minimum version of PyArrow is bumped, PyArrow will be bumped to the highest version that has been released for at least 2 years.". But pyarrow 10.0 was only released 1 year ago.
(and in general I also think 1 year is too short for pyarrow)
These versions will have been around for ~1 year once 2.2 comes out