-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR: fix stacklevel for DataFrame(mgr) deprecation #55591
Merged
jorisvandenbossche
merged 16 commits into
pandas-dev:main
from
jorisvandenbossche:fix-mgr-depr-warnings
Nov 9, 2023
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
81b2e47
DEPR: fix stacklevel for DataFrame(mgr) deprecation
jorisvandenbossche 2ff11b3
revert the added okwarning to user guide
jorisvandenbossche 0ab9c6a
revert changes to orc tests
jorisvandenbossche 864115f
revert/update some changes in parser tests as well
jorisvandenbossche 4c15c48
add back one doc okwarning
jorisvandenbossche bdebc9f
Merge remote-tracking branch 'upstream/main' into fix-mgr-depr-warnings
jorisvandenbossche 20dabc5
use stacklevel of 1
jorisvandenbossche ea2bf91
Revert "add back one doc okwarning"
jorisvandenbossche 7882d60
Merge remote-tracking branch 'upstream/main' into fix-mgr-depr-warnings
jorisvandenbossche 54a8591
fixup more tests
jorisvandenbossche 9042d97
fixup more tests
jorisvandenbossche 0bebb2c
Merge remote-tracking branch 'upstream/main' into fix-mgr-depr-warnings
jorisvandenbossche 172bd88
Merge remote-tracking branch 'upstream/main' into fix-mgr-depr-warnings
jorisvandenbossche 04ac100
Merge remote-tracking branch 'upstream/main' into fix-mgr-depr-warnings
jorisvandenbossche ece6c50
update comment
jorisvandenbossche 017f8d2
Merge remote-tracking branch 'upstream/main' into fix-mgr-depr-warnings
jorisvandenbossche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In several of those cases I removed the warning assert, and added a general filterwarnings mark (at the test or top of the file), because 1) there is no need to "test" that the warning is raised in all those cases, and 2) once the PR to fix this on the pyarrow side is merged, all those cases will start failing anyway