Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: Change stacklevel to 2 in DataFrame(mgr) deprecation #58694

Merged
merged 6 commits into from
Oct 30, 2024
Merged

DEPR: Change stacklevel to 2 in DataFrame(mgr) deprecation #58694

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
155dac4
DEPR: Change stacklevel to 2 in DataFrame(mgr) deprecation
Aloqeely May 13, 2024
6e5e6aa
Merge branch 'main' into depr-change-stacklevel
Aloqeely May 14, 2024
b067001
Merge branch 'main' into depr-change-stacklevel
Aloqeely May 14, 2024
0594e8c
Switch DeprecationWarning to FutureWarning
Aloqeely May 22, 2024
92eb560
Merge branch 'depr-change-stacklevel' of https://github.com/Aloqeely/…
Aloqeely May 22, 2024
582c6bc
Revert "Switch DeprecationWarning to FutureWarning"
Aloqeely May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,7 +718,7 @@ def __init__(
"is deprecated and will raise in a future version. "
"Use public APIs instead.",
DeprecationWarning,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this become a FutureWarning too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah probably, my intention of this PR was to just change the stacklevel considering pyarrow 15 was released. I guess it makes sense to change the warning class while I'm at it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would prefer waiting a bit longer with changing it to FutureWarning. At the very earliest, we can only remove this in pandas 4.0 with our current guidelines, so then we still have time to switch to a FutureWarning in any of the 3.x releases.

A reason to wait a bit longer for the FutureWarning is that if a user has pandas 3.0 with pyarrow 14 (not that old at this point), a FutureWarning would bubble up to the user while a DeprecationWarning stays hidden (while any direct user of it will still see the warning, which is what we care about most)

stacklevel=1, # bump to 2 once pyarrow 15.0 is released with fix
stacklevel=2,
)

data = data.copy(deep=False)
Expand Down