-
Notifications
You must be signed in to change notification settings - Fork 2
Scaling up the recipe with damip request #8
Conversation
🎉 New recipe runs created for the following recipes at sha
|
/run recipe-test recipe_run_id=283 |
/run recipe-test recipe_run_id=183 |
✨ A test of your recipe I'll notify you with a comment on this thread when this test is complete. (This could be a little while...) In the meantime, you can follow the logs for this recipe run at https://pangeo-forge.org/dashboard/recipe-run/283 |
✨ A test of your recipe I'll notify you with a comment on this thread when this test is complete. (This could be a little while...) In the meantime, you can follow the logs for this recipe run at https://pangeo-forge.org/dashboard/recipe-run/183 |
Pangeo Forge Cloud told me that our test of your recipe To see what error caused the failure, please review the logs at https://pangeo-forge.org/dashboard/recipe-run/183 If you haven't yet tried pruning and running your recipe locally, I suggest trying that now. Please report back on the results of your local testing in a new comment below, and a Pangeo Forge maintainer will help you with next steps! |
✨ A test of your recipe I'll notify you with a comment on this thread when this test is complete. (This could be a little while...) In the meantime, you can follow the logs for this recipe run at https://pangeo-forge.org/dashboard/recipe-run/185 |
When I tried to import your recipe module, I encountered this error
Please correct your recipe module so that it's importable. |
Pangeo Forge Cloud told me that our test of your recipe To see what error caused the failure, please review the logs at https://pangeo-forge.org/dashboard/recipe-run/185 If you haven't yet tried pruning and running your recipe locally, I suggest trying that now. Please report back on the results of your local testing in a new comment below, and a Pangeo Forge maintainer will help you with next steps! |
Ok I think I have figured the netcdf detection out! Thanks to @rabernat @cisaacstern and this doc. I have reduced the number of datasets to one member per model (assuming that the file format for the output does not change between modelling centers... |
@@ -330,6 +330,12 @@ def choose_chunksize( | |||
else: | |||
return output_chunksizes[0] | |||
|
|||
def is_netcdf3(url:str) -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
🎉 New recipe runs created for the following recipes at sha
|
/run recipe-test recipe_run_id=323 |
✨ A test of your recipe I'll notify you with a comment on this thread when this test is complete. (This could be a little while...) In the meantime, you can follow the logs for this recipe run at https://pangeo-forge.org/dashboard/recipe-run/323 |
/run recipe-test recipe_run_id=324 |
✨ A test of your recipe I'll notify you with a comment on this thread when this test is complete. (This could be a little while...) In the meantime, you can follow the logs for this recipe run at https://pangeo-forge.org/dashboard/recipe-run/324 |
/run recipe-test recipe_run_id=325 |
✨ A test of your recipe I'll notify you with a comment on this thread when this test is complete. (This could be a little while...) In the meantime, you can follow the logs for this recipe run at https://pangeo-forge.org/dashboard/recipe-run/325 |
/run recipe-test recipe_run_id=326 |
✨ A test of your recipe I'll notify you with a comment on this thread when this test is complete. (This could be a little while...) In the meantime, you can follow the logs for this recipe run at https://pangeo-forge.org/dashboard/recipe-run/326 |
/run recipe-test recipe_run_id=327 |
/run recipe-test recipe_run_id=332 |
✨ A test of your recipe I'll notify you with a comment on this thread when this test is complete. (This could be a little while...) In the meantime, you can follow the logs for this recipe run at https://pangeo-forge.org/dashboard/recipe-run/332 |
/run recipe-test recipe_run_id=333 |
/run recipe-test recipe_run_id=334 |
✨ A test of your recipe I'll notify you with a comment on this thread when this test is complete. (This could be a little while...) In the meantime, you can follow the logs for this recipe run at https://pangeo-forge.org/dashboard/recipe-run/333 |
/run recipe-test recipe_run_id=335 |
✨ A test of your recipe I'll notify you with a comment on this thread when this test is complete. (This could be a little while...) In the meantime, you can follow the logs for this recipe run at https://pangeo-forge.org/dashboard/recipe-run/334 |
✨ A test of your recipe I'll notify you with a comment on this thread when this test is complete. (This could be a little while...) In the meantime, you can follow the logs for this recipe run at https://pangeo-forge.org/dashboard/recipe-run/335 |
Yay, this looks like it works huh? Should I uncomment the remaining instance ids? |
Just to keep this intelligible, could we merge this, and then open a new PR which uncomments the remaining IDs? |
🎉 New recipe runs created for the following recipes at sha
|
/run recipe-test recipe_run_id=360 |
/run recipe-test recipe_run_id=361 |
🎉 New recipe runs created for the following recipes at sha
|
/run recipe-test recipe_run_id=362 |
/run recipe-test recipe_run_id=363 |
✨ A test of your recipe I'll notify you with a comment on this thread when this test is complete. (This could be a little while...) In the meantime, you can follow the logs for this recipe run at https://pangeo-forge.org/dashboard/recipe-run/363 |
✨ A test of your recipe I'll notify you with a comment on this thread when this test is complete. (This could be a little while...) In the meantime, you can follow the logs for this recipe run at https://pangeo-forge.org/dashboard/recipe-run/362 |
Yayyyy the netcdf3 detection works! Ill merge this now and try to push further on this throughout the day. |
This PR implements the first query from #3. I used my WIP parsing logic locally to generate the list of dataset_ids in the recipe and ran some quick QC locally:
There are two datasets (commented out) for which the ESGF API does not provide any urls. We need a good way to handle these cases (since they might be possible just intermittent). Ideas welcome.
There is an issue with some of the datasets being provided in fairly small files. @cisaacstern and I have talked about this and this can probably be resolved by expanding the dynamic kwargs logic to not just subset files but also combine them with
inputs_per_chunk
being determined dynamically aswell.But for now lets try these and see if that helps @rebeccaherman1