Make FSSpecTarget be 'pathlike' #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal here is for recipe authors to be able to pass *strings* to `target` parameters of StoreToZarr to specify where the data should be for this specific recipe, and we can inject the prefix with pangeo-forge-runner. The primary use case is when we have a dictionary of recipes being returned from a single recipe file. The *name* of the recipe is unfortunately not really available during AST parsing, so the suffix the data should be put in needs to be explicitly specified.
rabernat
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is for recipe authors to be able to
pass strings to
targetparameters of StoreToZarr to specify where the data should be for this specific recipe, and we can inject the prefix with pangeo-forge-runner.The primary use case is when we have a dictionary of recipes being returned from a single recipe file. The name of the recipe is unfortunately not really available during AST parsing, so the suffix the data should be put in needs to be explicitly specified.